-
Notifications
You must be signed in to change notification settings - Fork 468
Add SongBloom as a library #1571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Just a comment on the download counts but otherwise ready to merge.
(and I saw https://huggingface.co/models?other=songbloom is already populated 👍 )
repoName: "SongBloom", | ||
repoUrl: "https://github.com/Cypress-Yang/SongBloom", | ||
filter: false, | ||
countDownloads: `path_extension:"ckpt" OR path_extension:"pt"`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
countDownloads: `path_extension:"ckpt" OR path_extension:"pt"`, | |
countDownloads: `path:"songbloom_full_150s.pt", |
Let's count downloads on a single file to avoid duplicate counting (otherwise, downloading the repo would count a 2 downloads).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We plan to add other versions of the model into the repo, so maybe it should be path_extension:"pt"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We plan to add other versions of the model into the repo, so maybe it should be
path_extension:"pt"
If you have several variants of a model, it is highly recommended to upload them as 1 variant == 1 repo. Doing this has several benefits: per-variant download count (to gauge interest for each variation), better discoverability for users, per-variant community tab (for variant-specific questions), easier to document the differences between the models with 1 model card for model, etc. If you have 1 model == 1 repo, it's also recommended to use the same naming convention across repos => if a user fine-tunes one of your model, they can share it in their own repo and follow the same structure. The lineage between models is therefore easier to track (if documented in model cards).
All of this to say, I strongly recommend having 1 file pattern and count downloads based on that one - with 1 model == 1 repo. Note, that this is not a hard constraint and if you feel strongly about it, it's possible to do as you planned (but you loose some benefits listed above)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @Cypress-Yang - did you get the time to make those changes? As @Wauplin mentioned it would be good to split to one checkpoint per repo.
No description provided.